fix: allow excess protocol-specific fields on Binding (issue #735) - #1228
fix: allow excess protocol-specific fields on Binding (issue #735)#1228tzh476 wants to merge 2 commits into
Conversation
…#735) Change-Id: I2b53925665dd23e273e90fe42eb8ee90b4342907
🦋 Changeset detectedLatest commit: e365630 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Change-Id: Ie4f192783e7f7fb3e533f058974c6a5bb51a3eb8
|
|
Hi maintainers - friendly ping: this PR (fixes #735, binding excess properties) is ready and MERGEABLE, changeset added, CI/SonarCloud passing; happy to adjust on review. Thank you. |
1 participant
Fixes #735.
Adds a
[propName: string]: any;index signature to the v2 and v3Bindingspec-type interfaces (per the maintainer-approved approach), so protocol-specific binding fields such asclientIdare accessible without a cast.Binding.Verified: tsc --noEmit clean; v2 bindings 9/9; v3 bindings 8/8.